[build] Pre-build x86 viosock libraries as needed #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Pre-builds x86 viosock libraries when building virtio-win.sln or viosock.sln for amd64 in the circumstances the required x86 libraries do not already exist. Split from PR virtio-win#1212. Signed-off-by: benyamin-codez <[email protected]>
YanVugenfirer
requested changes
Dec 26, 2024
| @@ -162,6 +165,42 @@ set TARGET_VS_CONFIG="%TARGET_PROJ_CONFIG% %BUILD_FLAVOR%|%BUILD_ARCH%" | |||
| pushd %BUILD_DIR% | |||
| call "%~dp0\SetVsEnv.bat" %TARGET_PROJ_CONFIG% | |||
|
|
|||
| rem Check for x86 viosock libraries and build them if needed... | |||
| if "%BUILD_FILE%"=="virtio-win.sln" ( | |||
There was a problem hiding this comment.
Can he have this block as a separate batch file called form build.bat (prebuild_x86_vsock.bat)?
In the future, we will most probably have something similar for virtio-gpu as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86viosocklibraries when buildingvirtio-win.slnorviosock.slnforamd64in the circumstances the requiredx86libraries do not already exist.Split from PR #1212.